Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CLI-related make goals are confusing #89

Open
pires opened this issue Jun 7, 2018 · 1 comment
Open

CLI-related make goals are confusing #89

pires opened this issue Jun 7, 2018 · 1 comment

Comments

@pires
Copy link
Contributor

pires commented Jun 7, 2018

  • get-cli downloads kubectl and dcos to the working directory. It never checks if the binaries are already available, if the version matches, etc. before downloading, so every call downloads the binaries to the working directory.
  • setup-cli calls dcos from the working directory. It doesn't check if the binary is available, if the version matches, etc.

Then, references to kubectl always assume that kubectl is available in $PATH. If that's the case, we may end up with a kubectl v1.7.x in $PATH being called to interact with Kubernetes 1.10.3, even after get-cli downloaded kubectl v1.10.3 to the working directory.

I ran into this just now and it was painful to figure out.

My suggestion is to keep thing simple and just check for dcos and kubectl in $PATH, and show a warning about potential conflicts if their versions don't match the server-side versions.

@rimusz
Copy link
Contributor

rimusz commented Jun 15, 2018

yes, we do need to handle it in a better way

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants