[question] should skip_merge also include Merge pull request... messages

[hamza-shezad]

when skip_merge is true, should commits with messages as following be skipped?

Merge pull request #111 from <repo>`

[robinmayerhofer]

Docs

mergeable/docs/validators/commit.rst

Line 10 in 590a40f

skip_merge: true # Optional, Default is true. Will skip commit with message that includes 'Merge'

and implementation

mergeable/lib/validators/commit.js

Line 69 in 590a40f

orderedCommits = orderedCommits.filter(commit => !commit.message.includes('Merge branch'))

      orderedCommits = orderedCommits.filter(commit => !commit.message.includes('Merge branch'))

diverge. Merge vs. Merge branch.

=> Fix the implementation?

[hamza-shezad]

yes. do you want me to open a PR?

[robinmayerhofer]

Yes, I would suggest that you open a PR and ping the maintainers!