Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: support for Github Merge Queue #716

Open
davidalbers opened this issue May 17, 2023 · 1 comment
Open

Feature: support for Github Merge Queue #716

davidalbers opened this issue May 17, 2023 · 1 comment

Comments

@davidalbers
Copy link

davidalbers commented May 17, 2023

I'm testing Github merge queue and the Mergeable app doesn't run for PRs in the merge queue.

For some background: PR branches in the merge queue are rebased with the main branch. Then required PR checks must pass again before the original PR actually gets merged into the main branch.

I assume the issue is either that the app doesn't handle merge_group hooks or that a separate branch is made for PRs in the merge queue. For reference this seems to be a common issue.

Is there a way to handle checks in the merge queue? I'm thinking of something like when: merge_group.* or just having checks from a merge group be marked a "pass" since they already passed in the PR.

Side note: merge queue is a beta feature. One of the top requested (but not yet implemented!) features is to require a separate set of checks in the queue. So an alternative could be to wait for that capability and then I would not include mergeable in the queue checks.

@shine2lay
Copy link
Member

if they send over a webhook, you can add code to mergeable to be able to handle it. I suspect there will be a need to update permission in order to receive merge_group webhook events

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants