Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade Node Version 12 to Latest Node Version 19 #704

Open
akhilkumar438 opened this issue Mar 6, 2023 · 2 comments
Open

Upgrade Node Version 12 to Latest Node Version 19 #704

akhilkumar438 opened this issue Mar 6, 2023 · 2 comments

Comments

@akhilkumar438
Copy link

Hi - we're currently actively using the merge bot and the current base image node 12 its not supported anymore and also had some vulnerabilities so we want to upgrade to latest node version 19 before we that we want to make sure latest node version is supported or not.

@jusx @ketan @rtlechow @hemeroc @makuk66

@abid-mujtaba
Copy link
Contributor

I have had success with Node 18 with one caveat. Node 15, I believe, made unhandled Promise rejections an error instead of a warning and these crash the application. To fix this I added:

process.on('unhandledRejection', (reason, promise) => {
  console.log('WARNING: Ignoring unhandled promise rejection at:', promise, 'reason:', reason);
});

to the start of the index.js file.

@nightskyguy
Copy link

nightskyguy commented Apr 6, 2024

Version 2.17.6 references node 16; however when I attempt to start the container I get this message: Node.js version 18 is required. You have v16.20.2

When I change the dockerFile reference to Node 18, a test fails:

node[8]: ../src/node_platform.cc:68:std::unique_ptr<long unsigned int> node::WorkerThreadsTaskRunner::DelayedTaskScheduler::Start(): Assertion `(0) == (uv_thread_create(t.get(), start_thread, this))' failed.

However when I updated it to Node 19, it seems to work. But see #739 which says Node 20 will not work.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants