Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature: Require all codeowners #703

Open
Dylan-Prins opened this issue Mar 2, 2023 · 4 comments
Open

Feature: Require all codeowners #703

Dylan-Prins opened this issue Mar 2, 2023 · 4 comments

Comments

@Dylan-Prins
Copy link

I would love to have the option to require a review from all the codeowners. That way I can have different teams review the PR. Like Engineering and Risk
@dns2utf8-tipi
Copy link

Are you using the team or teams check?

@Dylan-Prins
Copy link
Author

Team

@dns2utf8-tipi
Copy link

I used an or stack to check for either group/team. I think you have to require a number of reviewer that you have to adjust according to the total number of members in all teams

@dns2utf8-tipi
Copy link

Checkout this implementation:
https://github.com/tipi-oss-testing/tipi-oss-test/blob/main/.github/mergeable.yml

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@Dylan-Prins @dns2utf8-tipi