Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HG: Add HG_Class_get_init_info #607

Open
mdorier opened this issue Jul 21, 2022 · 3 comments
Open

HG: Add HG_Class_get_init_info #607

mdorier opened this issue Jul 21, 2022 · 3 comments

Comments

@mdorier
Copy link

mdorier commented Jul 21, 2022

Is your feature request related to a problem? Please describe.

In the context of Margo, to fill up the JSON configuration that represents the parameters used to initialize Mercury, we would need to be able to retrieve the hg_init_info that was used to initialized Mercury if the user provided their own hg_class to Margo (or a default hg_init_info if HG_Init was used).

Describe the solution you'd like

struct hg_init_info* HG_Class_get_init_info(struct hg_class*)
@soumagne
Copy link
Member

OK. We currently do not keep that info around but that's probably possible to do it.

@soumagne
Copy link
Member

soumagne commented Dec 9, 2022

@mdorier let me know if you still need that feature. I've been looking at it recently and it's almost impossible to support it because of some the init info fields that would need to be copied and kept around. Some fields are cached but that's only a small part of them.

@soumagne soumagne changed the title Add HG_Class_get_init_info HG: Add HG_Class_get_init_info Dec 9, 2022
@soumagne soumagne added this to the future milestone Dec 9, 2022
@mdorier
Copy link
Author

mdorier commented Dec 9, 2022

It's definitely not a priority. I have modified margo to prevent it from assuming/reporting default values when HG was initialized externally.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants