Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HG: Add hg_proc_ignore #582

Open
mdorier opened this issue Jun 9, 2022 · 0 comments
Open

HG: Add hg_proc_ignore #582

mdorier opened this issue Jun 9, 2022 · 0 comments

Comments

@mdorier
Copy link

mdorier commented Jun 9, 2022

This function would have the following prototype:

hg_return_t hg_proc_ignore(hg_proc_t proc)

If the operation is HG_ENCODE or HG_FREE, this function would do nothing. If the operation is HG_DECODE, this function would ignore the remaining data, but be correct with respect to checksums.

This would fix an issue that appears when checksum is enabled and when the deserialization function registered with an RPC is trying to do something smart, such as figuring out half-way through deserialization that the remaining data won't be needed. In this situation currently Mercury will return a checksum error. This is a pattern we currently have in Margo, where if the beginning of the message indicates an error, the rest of the message is ignored. We have that also in thallium if the user tries to do partial deserialization, in which case an exception will be thrown if Mercury returns a checksum error.

@soumagne soumagne added this to the future milestone Dec 9, 2022
@soumagne soumagne changed the title Add hg_proc_ignore HG: Add hg_proc_ignore Dec 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants