Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HG Test: Tests may erroneously pass: error checking needs improvement #463

Open
gnuoyd opened this issue May 18, 2021 · 0 comments
Open
Milestone

Comments

@gnuoyd
Copy link
Contributor

gnuoyd commented May 18, 2021

This came up while debugging the UCX plugin for NA. The "lookup" test run by hg_test_rpc:hg_test_rpc_lookup() called hg_request_wait(request, HG_MAX_IDLE_TIME, NULL), which timed out after HG_MAX_IDLE_TIME milliseconds (30 seconds) because no progress was made. Since hg_test_rpc_lookup() did not check for an error return from hg_request_wait(), it continued with the next test step. In this way, the test took several minutes to complete, but it still passed.

@soumagne soumagne added this to the future milestone Oct 8, 2021
@soumagne soumagne changed the title Tests may erroneously pass: error checking needs improvement HG Test: Tests may erroneously pass: error checking needs improvement Oct 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants