Doesn't work with graphql v16+

[Manubi]

Hi,
just wanted to update the graphql package to version 16 but fastify/mercurius doesn't seem to like it.

No overload matches this call. Overload 1 of 3, '(plugin: FastifyPluginCallback<MercuriusOptions, Server>, opts?: FastifyRegisterOptions<MercuriusOptions> | undefined): FastifyInstance<...> & PromiseLike<...>', gave the following error. Type 'NexusGraphQLSchema' is not assignable to type 'string | GraphQLSchema | string[] | undefined'. Property 'isPossibleType' is missing in type 'NexusGraphQLSchema' but required in type 'GraphQLSchema'. Overload 2 of 3, '(plugin: FastifyPluginAsync<MercuriusOptions, Server>, opts?: FastifyRegisterOptions<MercuriusOptions> | undefined): FastifyInstance<...> & PromiseLike<...>', gave the following error. Argument of type 'typeof mercurius' is not assignable to parameter of type 'FastifyPluginAsync<MercuriusOptions, Server>'. Type 'void' is not assignable to type 'Promise<void>'. Overload 3 of 3, '(plugin: FastifyPluginCallback<MercuriusOptions, Server> | FastifyPluginAsync<MercuriusOptions, Server> | Promise<...> | Promise<...>, opts?: FastifyRegisterOptions<...> | undefined): FastifyInstance<...> & PromiseLike<...>', gave the following error. Type 'NexusGraphQLSchema' is not assignable to type 'string | GraphQLSchema | string[] | undefined'.ts(2769) schema.d.ts(83, 3): 'isPossibleType' is declared here.

Thanks for your help!

[mcollina]

Seems about right, we have not updated to GraphQL v16 yet.

[mcollina]

Would you like to send a Pull Request to address this issue?

[Manubi]

Guess that doesn't make sense right now.
graphql-shield doesn't have updated to v16 either. PR

Also why this PR for an update of graphql in mercurius failed. PR

[giacomorebonato]

Hi @Manubi , the PR seems to be failing because of this:

npm ERR! Could not resolve dependency:
npm ERR! peer graphql@"^0.12.0 || ^0.13.0 || ^14.0.0 || ^15.0.0" from graphql-middleware@6.1.12
npm ERR! node_modules/graphql-middleware

graphql-middleware (Mercurius dev dependency) has peer dependency on graphql < 16, so it needs to be upgraded too.

[mcollina]

We can actually remove that dependency and add the relative example: https://github.com/mercurius-js/mercurius/blob/b671de31178395ea53f2ea39c19cc3f8d80be8eb/examples/graphql-shield-authorization.js.
That dependency is not needed to run, build or test Mercurius.

[giacomorebonato]

Thanks @mcollina , I'll look into that.

[DanTsk]

Any updates on this?

[mcollina]

Any updates on this?

Would you like to work on it?

[DanTsk]

Any updates on this?

Would you like to work on it?

Yes, on the next week I will have some capacity to fix this, but don’t want to interrupt someone’s existing work.

[mcollina]

Go for it!

[giacomorebonato]

Sorry, I can't help with this at the moment