Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Proxy setup only working with nessus #3081

Open
de-jcup opened this issue Apr 18, 2024 · 0 comments
Open

Proxy setup only working with nessus #3081

de-jcup opened this issue Apr 18, 2024 · 0 comments
Labels

Comments

@de-jcup
Copy link
Member

de-jcup commented Apr 18, 2024

Situation

We have the class ProxyConfig which is extended for all adapter configurations in SecHub. While doing changes for #797 it become clear that the current situation is as following:

  • Only adapters have currently a proxy support via TrustAll
  • But none of the adapters config builders does call at least setProxyHostname - except the Nessus Adapter (which is deprecated)!
  • It is also no part of the PDS default parameters!

As a sum up:
The proxy settings can currently not work (except Nessus) where it can be defined by system properties (or env entries) via

sechub.adapter.nessus.proxy.hostname
sechub.adapter.nessus.proxy.port

Wanted

The proxy handling shall be consistent

Solution

Introduce single spring value and use it inside every executor

sechub.adapter.proxy.hostname
sechub.adapter.proxy.port

like done for Nessus executor (but replace nessus variant with this as well) for every executor.

@de-jcup de-jcup added the proxy label Apr 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant