Malformed channel topic links

[andresf]

This is an example of the current generated link:

school.mendicantuniversity.org/chat/messages**?&channel=#**mendicant-alumni&topic=Web%20Apps/Tools%20Meeting&full_log=true

There is an extra ampersand at the start of the params (after '?'). This is ignored by Firefox, but other browsers might choke.

The '#' needs to be replaced by '%23'. This one does make things go sour.

[wicz]

The extra ampersand is really an issue. Not a terrible one, though.

About the pound sign, that's awkward cause since the very first commit of this feature the URI is being properly encoded. See 734dce8. Maybe a bug in Cinch?

[andresf]

I think we need to figure out what m.channel.name is returning first, and perhaps add some tests! I'm confused as to what some methods are expecting.

That said, I'm puzzled. I can't think of anything that would return '#' after going through URI#encode.