Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Restore the people list #60

Open
jordanbyron opened this issue Feb 15, 2012 · 10 comments
Open

Restore the people list #60

jordanbyron opened this issue Feb 15, 2012 · 10 comments
Assignees
Labels

Comments

@jordanbyron
Copy link
Contributor

This lists should be visible to logged in users only.
Split users into two sections:

Top section will list users with profiles (Sorted by name)
Below that section, a header "Lazy Unicorns" will list users without profiles

Paginated. Search isn't required as #12 will take care of that.

@gjp
Copy link
Contributor

gjp commented Feb 15, 2012

I'd like to work on this one.

here's the commit which removed the people index for reference.

Do you want me to more or less undo this commit, minus the filter code, plus the lazy unicorns breakdown?
Is there a clean way to undo an old commit without making a mess? (my git-fu is weak)

Would you like me to adjust the formatting in some way? Simple list vs. alumni-style grid, decorated or not?

Is respond_to js still needed? I'm not clear on whether that was part of the filter.

@ghost ghost assigned gjp Feb 15, 2012
@jordanbyron
Copy link
Contributor Author

I'd like to work on this one.

It's all yours

Do you want me to more or less undo this commit, minus the filter code, plus the lazy unicorns breakdown?

I wouldn't. Let's start fresh and just use the old code as a guide.

Would you like me to adjust the formatting in some way?

Start off with something very simple: Gravatar and name. Might make sense to do a few mockups if that's something you are comfortable with.

Is respond_to js still needed? I'm not clear on whether that was part of the filter.

That was for the filter which we don't need to support in the new version.

Good luck ✨

@gjp
Copy link
Contributor

gjp commented Feb 15, 2012

Putting the index back in was easy, now I'll definitely want to do mockups. Have we got a set of test data, or a list of people available from an API? Otherwise I'll need to set up factory script a la puzzlenode, or a scraper, or (ugh) data entry. Real data is the best data, as with the Nerian Test ™️

@gjp
Copy link
Contributor

gjp commented Feb 16, 2012

Or I could write a scraper which slurps alumni github account names and fetches their email addresses using github's user API so I can do the mockup with their gravatars.

🐑

Hack day is starting early over here.

@jordanbyron
Copy link
Contributor Author

@gjp sadly we currently don't have any seed data. Sounds like you've created another ticket. I've been working off a backup from the live site, but we should have some valid data for new developers to work with.

I've created ticket #66 and outlined some of my ideas there.

@gjp
Copy link
Contributor

gjp commented Feb 16, 2012

re: scraper - I actually did that, and loaded my dev db from a CSV file. As badass as the default unicorn picture is, I wanted to see more than one gravatar on the page :)

I tried a basic list view and found it didn't look too great. As this whole thing is provisional, what if I borrow the 3 column style used on the current alumni list?

@jordanbyron
Copy link
Contributor Author

As this whole thing is provisional, what if I borrow the 3 column style used on the current alumni list?

Hard to say. I'd have to see the design.

@gjp
Copy link
Contributor

gjp commented Feb 16, 2012

I'll get you a screenshot when this looks less like I've just pasted styles from one site into another :)

@gjp
Copy link
Contributor

gjp commented Feb 22, 2012

just dropping this in here for when you have time.
mock-01

D's comments: "Kind of busy. Bigger gutter." At which point I realize I don't know how to create a gutter without using uneven left and right margins on the items and a negative margin on the container.

Also, how should Lazy Unicorns interact with pagination? Seems we'd need two independent lists, each with a paginator. Perhaps two links in the upper right?

@gjp
Copy link
Contributor

gjp commented Feb 29, 2012

@jordanbyron If you have time to discuss the above, I think I can wrap this up pretty quickly.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants