Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add RTSP server #683

Open
varsill opened this issue Nov 21, 2023 · 5 comments
Open

Add RTSP server #683

varsill opened this issue Nov 21, 2023 · 5 comments

Comments

@varsill
Copy link
Contributor

varsill commented Nov 21, 2023

Currently, the membrane_rtsp package (https://github.com/membraneframework/membrane_rtsp) contains only RTSP client, capable of receiving RTSP messages.
Adding the corresponding RTSP server functionality (so that the user would be able to send RTSP messages) should be problematic and definitely it would be helpful, because we then could use such a server e.g. in our rtsp_to_hls demo.
Apart from them, I believe the package name should be converted to ex_rtsp to follow our naming conventions.

@varsill
Copy link
Contributor Author

varsill commented Nov 27, 2023

It has turned out that there is already an implementation of a simple RTSP server in Jellyfish. I slightly modified it and added it to the rtsp_to_hls demo: https://github.com/membraneframework/membrane_demo/blob/master/rtsp_to_hls/server.exs

@mat-hek
Copy link
Member

mat-hek commented Nov 28, 2023

@varsill should we close this then?

@varsill
Copy link
Contributor Author

varsill commented Dec 4, 2023

As discussed - closing since no further development is required at this moment. In the future, we might want to rewrite the RTSP server in such a manner, that each message could be responded to within a callback.

@varsill varsill closed this as completed Dec 4, 2023
@gBillal
Copy link

gBillal commented Jan 31, 2024

Hi @varsill @mat-hek
Since I also need an RTSP server, I decided to create a fork of membrane_rtsp taking inspiration from the server example mentioned in this issue. This is the work done so far.
It's not yet finished as I'm trying to wrap my head around the RFC. If you think we can add it to membrane_rtsp I'll create a PR.

@mat-hek
Copy link
Member

mat-hek commented Feb 1, 2024

Hi, it looks good to me! Feel free to open a PR, thanks ;)

@mat-hek mat-hek reopened this Feb 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants