Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement batch_memorize control plane api for MeMaS #6

Open
maxyu1115 opened this issue Aug 18, 2023 · 1 comment
Open

Implement batch_memorize control plane api for MeMaS #6

maxyu1115 opened this issue Aug 18, 2023 · 1 comment
Assignees
Labels
enhancement New feature or request

Comments

@maxyu1115
Copy link
Collaborator

maxyu1115 commented Aug 18, 2023

Implement the batch_memorize api for memas. This will be used to mostly for mass import scenarios, like populating knowledge corpora.

The json payload for the api call will most likely look something like this:

{
    "corpus_pathname": "aaa.bbb:ccc",
    "cited_documents": [
        {
            "document": "...",
            "source_uri": "...",
            ...
        },
        {
            "document": "...",
            "source_uri": "...",
            ...
        }
    ]
}

For now, a basic loop and insert on the server side should suffice. Feel free to go above and beyond implementing a batch insert on the corpus level as well.

@maxyu1115 maxyu1115 added the enhancement New feature or request label Aug 18, 2023
@maxyu1115 maxyu1115 changed the title Implement batch_remember control plane api Implement batch_remember control plane api for MeMaS Aug 18, 2023
@maxyu1115
Copy link
Collaborator Author

maxyu1115 commented Aug 18, 2023

Most of the work will be done in controlplane.py, along with needed tests and corpus changes.

def remember():
Is a good reference

@AlexArtrip AlexArtrip self-assigned this Aug 19, 2023
@maxyu1115 maxyu1115 assigned mmmyr and unassigned AlexArtrip Aug 21, 2023
@maxyu1115 maxyu1115 changed the title Implement batch_remember control plane api for MeMaS Implement batch_memorize control plane api for MeMaS Aug 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants