Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Gradle jmh task still succeed when JMH fails. #255

Open
robin-aws opened this issue Jul 12, 2023 · 0 comments
Open

Gradle jmh task still succeed when JMH fails. #255

robin-aws opened this issue Jul 12, 2023 · 0 comments

Comments

@robin-aws
Copy link

Describe the bug
See title.

To Reproduce
Create a benchmark method that always throws an exception and ensure failOnError is true. The exception will print out and JMH will report failure, but Gradle will still report "BUILD SUCCESSFUL". (Working on setting up this repo locally and making a unit test to confirm).

Root cause is failing to check the exit code after spawning the process to call JMH: https://github.com/melix/jmh-gradle-plugin/blob/master/src/main/java/me/champeau/jmh/JMHTask.java#L70

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant