-
Notifications
You must be signed in to change notification settings - Fork 2.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Consider to use FlatList. #73
Comments
Hello folks, I am interested in using What do you guys think getting started with a port to ListView first?
It seems that switching to It also looks like If you guys agree with this direction would you be interested in starting a new branch that ports |
@PublicParadise Note that there is one major drawback with using either With that in mind, it would be great to offer the best of both worlds:
I need to play with the code to see how maintainable that would be. Ideas and suggestions are very welcome ;-) |
@PublicParadise Well, forget about what I just said; the prop So let's focus on migrating to |
@bd-arc I like the idea of offering both worlds. You could always decide later if you want to retire the |
hi do you have any clue when this will be finished? really looking forward to the flatlist version! |
Hi @EdmundMai, I should be able to work on it this week or the the week after. Stay tuned! |
@bd-arc awesome, thanks so much for this library!! |
Is facebook/react-native#14037 still an issue? It looks like it was closed for lack of data? Does a throttle fix it sufficiently? |
I am also having perfomance issues with this library. Please use flatlist. |
Ok guys, I've got some good news: Currently checking if something obvious has been broken and implementing a few things, and then it's yours to try ;-) |
And here we are! I've just pushed a I've tested it thoroughly in real projects and it seemed pretty good to me (even though Now here is the deal: I need feedback on this update. Be aware that I won't publish it until I've made sure that it hasn't broken anything serious. To make testing easier, the branch includes an updated README as well as an updated example ;-) |
It works very well with FlatList! Thanks! However, if data array is empty, it throws the error Looking forward to the release! |
Thanks for noting this issue @mazing! I never initialize my carousels while data hasn't been fetched, which is why I tend to overlook this kind of error. I'll shortly push a fix. |
Hi! How can I install this flatlist version by using npm? I would like to be a little white mouse to experiment this feature :-) |
yes just use the GitHub link instead of version and point to the flatlist branch using # |
Hi @jarvisluong, @scerelli said it all :-) To get the current latest commit of the
Don't forget to check the updated documentation as well as the migration guide. Looking forward to your feedback ;-) |
Hi guys, Here comes a pretty neat feature I've been working on during the past few days because I needed it for a project: parallax images, native driver-powered 🍾 As usual, documentation and example have been updated. Let me know what you think! |
So far the FlatList version is working marvelously 👍 . The performance really bumped up! |
Thanks for the feedback @jarvisluong! I've squashed a few bugs today but yes, the new implementation seems to work as expected. I'm now going to work on implementing a proper loop mode. If no major issue has been reported since then, it will probably be a good time to release version 3.0.0 ;-) |
I had some troubles updating to react-native v0.47.0. First, I received errors about |
Hey @mazing, I've just updated the example to RN v0.47.1 (see the latest commit) and didn't have any issue. Would you mind trying it and letting me know if you still have troubles? |
I'm sorry - my bad! When I reinstalled, I forgot to install the flatlist branch, so the items were simply not shown, since I only had a |
@mazing Do you mind copying/pasting your latest comment into a dedicated issue? I think it might have to do with your setup and not with the |
Version 3.0.0 has been published! |
Did you consider to use
FlatList
instead ofScrollView
? it will improve a lot performance and it has lazy load for items that works properlyThe text was updated successfully, but these errors were encountered: