Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature Request] Interop with react-native-gesture-handler #466

Closed
siderakis opened this issue Jan 31, 2019 · 3 comments
Closed

[Feature Request] Interop with react-native-gesture-handler #466

siderakis opened this issue Jan 31, 2019 · 3 comments

Comments

@siderakis
Copy link

In react-native-snap-carousel the ScrollView and FlatList implementations are hard coded to the ones provides by "react-native".

Can we add a prop to allow users to provide their own wrapped versions of ScrollView and FlatList, similar to how FlatList allows you to provide a wrapped implementation of ScrollView using the renderScrollComponent prop.

This would allow users to use the wrapped FlatList and ScrollView provided by react-native-gesture-handler.

Background

react-native-gesture-handler allows you to specify a waitFor prop on a ScrollView that tells the ScrollView to wait for other gesture handlers to become active or not. For example there could be a Slider component within a horizontal scrollview.

@martinezguillaume
Copy link
Contributor

Waiting for this !

@bd-arc
Copy link
Contributor

bd-arc commented Mar 27, 2019

If someone wants to jump in and submit a clean PR for that, I'll be more than happy to merge it!

@martinezguillaume
Copy link
Contributor

Here we go !

@bd-arc bd-arc closed this as completed Dec 18, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants