Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Maintaining this plugin #210

Open
GabrielMcNeilly opened this issue Mar 10, 2022 · 8 comments
Open

Maintaining this plugin #210

GabrielMcNeilly opened this issue Mar 10, 2022 · 8 comments
Assignees
Labels
bug Something isn't working

Comments

@GabrielMcNeilly
Copy link

@meinaart Can you give me/someone/others permissions to approve/merge PRs etc for this project?

It's a pretty nice plugin but it is in need of a fair amount of updates. I and others would be interested in contributing/maintaining it if you are no longer able to do so.

Currently it seems it is being left to stagnate and will soon be unusable. Given there is no fantastic visual testing Cypress plugin imho, this has the opportunity to be the main one so it seems a waste to just leave it especially when there are people willing to contribute.

@GabrielMcNeilly GabrielMcNeilly added the bug Something isn't working label Mar 10, 2022
@inovramadani
Copy link

Absolutely agree with @GabrielMcNeilly. This plugin causing crashes on my cypress because its specific dependency to cypress 4.5.0. It should have been sth like cypress > 4.5.0 maybe?

@lmiller1990
Copy link

lmiller1990 commented Apr 19, 2022

I am also curious about the future of the plugin. I can help out - I have deep knowledge on Cypress internals. I'd say the first step would be updating to each major Cypress version.

The best option might simply be to fork or move the plugin to it's own org, if the original author is no longer using it or able to maintain it.

@dhulme
Copy link

dhulme commented May 9, 2022

See this thread: #194

I think there is still an issue with the github actions with are blocking PRs. I had a look at it last year but got a bit stuck. Maybe you have an idea?

I think @joetidee and @edimitchel have permission to merge PRs.

@edimitchel
Copy link

Not anymore, PR are failing and we cannot override PR restriction in case of PR build failing..

@gearsdigital
Copy link

The best option might simply be to fork or move the plugin to it's own org, if the original author is no longer using it or able to maintain it.

What does @meinaart say about that? Are you still interested in maintaining the plugin? Otherwise it might be a good idea to transfer the ownership to someone else. @lmiller1990 seems to be the perfect fit 😅

@dhulme What is the issue with the github actions?

@dhulme
Copy link

dhulme commented Aug 14, 2022

We've now migrated to https://github.com/FRSOURCE/cypress-plugin-visual-regression-diff which works fine with Cypress 10 🥳

@david-renner-dwg
Copy link

@dhulme How difficult was the migration to https://github.com/FRSOURCE/cypress-plugin-visual-regression-diff? I'm trying to set up github actions for my org's cypress testing and it looks like we're going to need an alternative to cypress-plugin-snapshots. My organization is still using v8.4.1, if that matters.

@dhulme
Copy link

dhulme commented Aug 17, 2022 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

8 participants