Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve the test structure by reducing duplication #287

Open
4 tasks
brunoocasali opened this issue Jan 11, 2022 · 0 comments
Open
4 tasks

Improve the test structure by reducing duplication #287

brunoocasali opened this issue Jan 11, 2022 · 0 comments
Labels
enhancement New feature or request help wanted Extra attention is needed

Comments

@brunoocasali
Copy link
Member

After #237 #217 which adds snake_case support, we improve our public API to be more idiomatic.
But we introduced a new problem regarding the tests.

In this comment, I raise the problem to @curquiza about a way to reduce this duplication without losing our coverage on each topic.

One possible question to be answered in this issue is: do we really need to test the snake_case support in every public method? Or just ensuring they will be parsed correctly is enough?

If we don’t need to test we should:

  • Remove all the already duplicated test use-cases.
  • Ensure that we will have a good coverage about ensuring the params parsing for each method.

otherwise:

  • Provide a way to test these multiple ways to send the params (using snake_case or not) without duplication.
  • Refactor the specs to support this new way to do tests.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

2 participants