Skip to content
This repository has been archived by the owner on May 13, 2021. It is now read-only.

Linter #4

Closed
3 tasks
curquiza opened this issue Apr 18, 2020 · 2 comments 路 Fixed by #39
Closed
3 tasks

Linter #4

curquiza opened this issue Apr 18, 2020 · 2 comments 路 Fixed by #39
Assignees
@curquiza
Labels
Laravel integration
Projects
SDKs & Integrations

Comments

@curquiza
Copy link
Member

We should have a linter so that everyone can easily contribute without messing the code 馃檪

Steps:

  • Add and configure the linter
  • Add the command in README in the Development Workflow part
  • Add it in GitHub Action to be triggered on each PR
@curquiza curquiza added this to Open issues in SDKs & Integrations via automation Apr 22, 2020
@pet1330
Copy link
Contributor

pet1330 commented Apr 24, 2020

You can quickly automate this step by using styleci, it is free for opensource

@curquiza
Copy link
Member Author

curquiza commented May 13, 2020 •
edited

Thanks for the suggestion @pet1330! 馃槉

After discussing with the team, we would rather not to use styleCI since it needs to access to our organization content:
Capture d鈥檈虂cran 2020-05-04 a虁 17 11 01

We are going to install a basic linter like php-cs-sniffer (already used in the PHP SDK).

@curquiza curquiza self-assigned this Aug 20, 2020
@curquiza curquiza mentioned this issue Aug 20, 2020
Merged
SDKs & Integrations automation moved this from Open issues to Done Aug 21, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@curquiza curquiza

Labels
Laravel integration
Projects
No open projects
SDKs & Integrations
Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add linter meilisearch/meilisearch-laravel-scout
2 participants
@pet1330 @curquiza