Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added name explanation in README #104

Closed
wants to merge 3 commits into from
Closed

Added name explanation in README #104

wants to merge 3 commits into from

Conversation

Mount-Blanc
Copy link

What does this PR do?

Fixes #102

PR checklist

Please check if your PR fulfills the following requirements:

  • Does this PR fix an existing issue?
  • Have you read the contributing guidelines?
  • Have you made sure that the title is accurate and descriptive of the changes?

curquiza
curquiza requested changes May 24, 2022
View reviewed changes
Copy link
Member

@curquiza curquiza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello @Mount-Blanc

Thanks for your PR

We would expect a more README-friendly explanation than a copy/paste 😇
Can you improve this?

@Mount-Blanc Mount-Blanc requested a review from curquiza May 28, 2022 20:42
@CaroFG
Copy link
Contributor

CaroFG commented Jun 1, 2022

I am sorry to intrude. I was the one who suggested creating a section in the README explaining the name. I feel like the responsible(s) for explaining the name must be the person who came up with it. It's difficult for an external contributor to know exactly what "we" want to convey

@curquiza
Copy link
Member

curquiza commented Jun 1, 2022

Hello again @Mount-Blanc, as @CaroFG said, this is something I should have assigned the issue to her from the beginning. I'm sorry for the confusion, this is my mistake, and thanks again for the time you spent contributing to Meilisearch
I close this issue then, Caro will do it when she is available.

@curquiza curquiza closed this Jun 1, 2022
@curquiza curquiza mentioned this pull request Jun 1, 2022
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@curquiza curquiza Awaiting requested review from curquiza

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Explain the name of the repo in the README
3 participants
@Mount-Blanc @CaroFG @curquiza