Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Is DOT adaptable to other optimizer? #52

Open
Vickeyhw opened this issue Nov 12, 2023 · 3 comments
Open

Is DOT adaptable to other optimizer? #52

Vickeyhw opened this issue Nov 12, 2023 · 3 comments

Comments

@Vickeyhw
Copy link

The implementation of DOT seems based on SGD with momentum. Since vision transformers usually use AdamW as optimizer, how about adapting the DOT to other optimizer such as AdamW or Lamb?

@Zzzzz1
Copy link
Collaborator

Zzzzz1 commented Nov 20, 2023

Technically, DOT could be adopted to optimizers with momentum. You can implement DOT-AdamW based on the released code.

@Vickeyhw
Copy link
Author

@Zzzzz1 Thank you! Another question is why DDP is not adopted? I noticed that you use DP, but the DDP is more efficient. When I use DDP, the two back propagations in each iteration seem hinder the loss decrease, especially when using multiple gpus. Do you have any good ideas?

@Zzzzz1
Copy link
Collaborator

Zzzzz1 commented Nov 29, 2023

@Zzzzz1 Thank you! Another question is why DDP is not adopted? I noticed that you use DP, but the DDP is more efficient. When I use DDP, the two back propagations in each iteration seem hinder the loss decrease, especially when using multiple gpus. Do you have any good ideas?

DOT needs to maintain momentum_kd and momentum_ce at the same time. Maybe
it has a conflict with DDP's implementation of updating parameters.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants