Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

redo mask interface #3

Open
mef51 opened this issue Jan 19, 2022 · 3 comments
Open

redo mask interface #3

mef51 opened this issue Jan 19, 2022 · 3 comments
Labels
feature New feature or request

Comments

@mef51
Copy link
Owner

mef51 commented Jan 19, 2022 •
edited

  • add file dialog for exporting masks
  • display the masks in a way that can handle many masks (the table is awful)
  • enable masking by range
  • encode masks in results spreadsheet if possible
@mef51 mef51 changed the title add file dialog for exporting masks redo mask interface Jan 19, 2022
@mef51 mef51 added the feature New feature or request label Feb 8, 2022
mef51 added a commit that referenced this issue Mar 26, 2022
@mef51
add range masking in addition to clicking single channel masking #3
d1c060e
@mef51
Copy link
Owner Author

mef51 commented Jun 8, 2022

add a column for the masks and encode masks like
1-10;14;18;19-25

or some format like that that doesnt use commas

mef51 added a commit that referenced this issue Aug 25, 2023
@mef51
update frbgui to dearpygui 1.9 api, multiple fixes and improvements
8fe1409 
* runs on mac M2 (closes #22)
* mask table scrolls and gracefully handles large amounts of masks (wip #3)
* update and theme results table
* add dependencies to setup
* reshape matplotlib texture for dpg's rgba format, plot with new api
* switch to dearpygui_ext logger for now
* remove some dead code, stale todos. Use `data` in callbacks when appropriate
* update some callbacks to (sender, data, userdata) signature based on usage
* properly store, export, and import mask ranges (wip #3)
* input fields that have no effect are greyed out
* implement wfall and corr2d plot scale sliders. default is max(corr)/20
* DM save button is disabled when the DM is the same as the saved copy
* set line series color with theme (prevents color flickering)
* update regions and set region lines with theme
* remove "Export Regions" button (regions are encoded in results)
* add themes options in menubar
* sort burst files explicitly since mac and linux do not sort directories by default
* use agg backend when generating texture for the gui
	* this is  workaround for matplotlib being on a callback thread
* export pdf on main thread (with manual render loop) since matplotlib doesn't like being on a thread
* sleep one frame when updating corr2d texture due to DPG bug
	* hoffstadt/DearPyGui#2159
* add icon but it doesn't seem to work on mac
* set default position of window
@mef51
Copy link
Owner Author

mef51 commented Sep 13, 2023

Making a mask range larger than the shape of the waterfall appears to completely hang the program (force quit needed)

@mef51
Copy link
Owner Author

mef51 commented Sep 13, 2023

Maybe use the frequency instead of the channel numbers for mask ranges. This is more informative

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
feature New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@mef51