Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Should hasDirectMessages be hasIndirectMessages? #15

Open
bittner opened this issue Nov 12, 2019 · 1 comment
Open

Should hasDirectMessages be hasIndirectMessages? #15

bittner opened this issue Nov 12, 2019 · 1 comment

Comments

@bittner
Copy link

bittner commented Nov 12, 2019

I see in package.json that you use the hasDirectMessages flag.

Interestingly, the documentation doesn't mention that flag. Instead, it mentions a flag with the reverse logic:

boolean hasIndirectMessages default: false

Is this a bug? And, is the documentation wrong or the implementation in the JSON file?

I may have seem this implementation in other recipes as well.

@hongshaoyang
Copy link

Seems that it's a leftover configuration that was removed or modified:

https://github.com/meetfranz/franz/search?q=hasdirectmessages&unscoped_q=hasdirectmessages

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants