Skip to content
This repository has been archived by the owner on Oct 30, 2022. It is now read-only.

@types/sinon and other dependant types should be included as dependencies #186

Open
ksaaskil opened this issue Aug 23, 2019 · 1 comment
Open

@types/sinon and other dependant types should be included as dependencies #186

ksaaskil opened this issue Aug 23, 2019 · 1 comment
Labels
bug Something isn't working good first issue Good for newcomers help wanted Issue needs help

Comments

@ksaaskil
Copy link
Contributor

Otherwise installers of unmock need to install those types themselves. Shipping types as "production" dependencies is the recommended approach here.
@ksaaskil ksaaskil added bug Something isn't working good first issue Good for newcomers labels Aug 23, 2019
@ksaaskil
Copy link
Contributor Author

Dependencies to lerna packages can be added most easily with the lerna add command.

@ksaaskil ksaaskil mentioned this issue Aug 30, 2019
Closed
@carolstran carolstran added the help wanted Issue needs help label Dec 12, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
bug Something isn't working good first issue Good for newcomers help wanted Issue needs help
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@ksaaskil @carolstran