Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

{resolution} results in the output of 'premium' when TubeSync downloads a Premium source. #499

Open
AshleyAshes opened this issue May 8, 2024 · 4 comments

Comments

@AshleyAshes
Copy link

I didn't even realize that TubeSync could download the 'Premium' flagged encodes, but nifty. That said it's not giving me a resolution from the {resolution}.

I'm currently using this formatting:

{source_full} {yyyy_mm_dd} {title_full} [{resolution} WEB-DL].{ext}

And now have some files coming in like this:

Nostalgia Nerd 2021-11-17 This Mysterious Computer Could Prove Time Travel Exists Nostalgia Nerd [premium WEB-DL].mkv

'Premium' doesn't really tell me what resolution the file is, since, AFAIK, Premium could be any number of resolutions, depending on what the highest uploaded resolution is.

@AshleyAshes
Copy link
Author

AshleyAshes commented May 8, 2024

Oh, apparently ditto for some files reporting their framerate despite never using the {fps} tag in my filenames. Seems to only be happening if the framerate is 50fps.

Example:

Nostalgia Nerd 2020-02-12 Exploring a LOAD of Dutch Computers! Nostalgia Nerd [1080p50 WEB-DL].mkv

@meeb
Copy link
Owner

meeb commented May 9, 2024

Thanks, there's obviously been some changes on the YouTube side that I need to update in tubesync. tubesync itself doesn't "support" premium streams, it's really just a web UI wrapper around yt-dlp which does all of the heavy lifting so it'll support whatever yt-dlp upstream supports. It has some logic in it for the file naming though which is probably where this issue is hiding. I don't have a YouTube account myself so issues with premium flagged formats generally require people like you to report them here as I can't stumble over and see them myself.

I'll look into this before the next release.

@AshleyAshes
Copy link
Author

Yeah, so about that 'YouTube Account' thing. I've done nothing to enter my YT account info into TubeSync and I don't pay for YT premium anyway. I don't know how it downloaded something 'Premium' if it really did,

@meeb
Copy link
Owner

meeb commented May 9, 2024

Ah fair enough. It's likely that YouTube are occasionally presenting "premium" streams for non-premium and not authenticated users then, or at least offering them as formats which you can't access. Either way it's a change at YouTube which will need investigation and updating in tubesync to account for it. Cheers for the details.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants