Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update-config incorrectly detects conflict in storage-base-url #4495

Open
rahul1 opened this issue May 2, 2024 · 0 comments
Open

update-config incorrectly detects conflict in storage-base-url #4495

rahul1 opened this issue May 2, 2024 · 0 comments
Assignees
@codyebberson
Labels
bug Something isn't working self-host Features and fixes related to self hosting

Comments

@rahul1
Copy link
Member

rahul1 commented May 2, 2024

Repro

On an existing stack, run medplum aws update-config without making any changes to the config.json

Expected Behavior

No confilict notification

Observed Behavior

Infra "storageDomainName" (${infraConfig.storageDomainName}) does not match server "storageBaseUrl" (${serverConfig.storageBaseUrl})

Root Cause

When we set the storageBaseUrl, we append a path /binary/ to the storageDomainName

storageBaseUrl: https://${config.storageDomainName}/binary/,

  • When we check for conflicts, we don't append the binary

checkConflict(
@rahul1 rahul1 added bug Something isn't working self-host Features and fixes related to self hosting labels May 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@codyebberson codyebberson

Labels
bug Something isn't working self-host Features and fixes related to self hosting
Projects
Medplum Product Roadmap
Status: No status
Milestone
No milestone
Development

No branches or pull requests
2 participants
@codyebberson @rahul1