chore(#9100): move cht-form tests to integration #9103
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lorerod
changed the title
jkuester
approved these changes
May 9, 2024
| @@ -1,4 +1,4 @@ | |||
| const wdioBaseConfig = require('../wdio.conf'); | |||
| const wdioBaseConfig = require('../../e2e/wdio.conf'); | |||
There was a problem hiding this comment.
Minor, but what do you think about moving this wdio.conf file up a level so it is just tests/wdio.conf (and not nested in tests/e2e)? I just think that might make it a bit easier to remember that it is getting referenced from outside the tests/e2e folder....
If it looks like it might be tricky to move wdio.conf, then def don't worry about it!
added 2 commits
May 9, 2024 11:47
…move-cht-form-to-integration-test
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Closes #9100
Code review checklist
Compose URLs
If Build CI hasn't passed, these may 404:
License
The software is provided under AGPL-3.0. Contributions to this project are accepted under the same license.