Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Disable Aggregate Targets for users with multiple facility_ids #114

Open
Tracked by #120
michaelkohn opened this issue Apr 29, 2024 · 4 comments · May be fixed by medic/cht-core#9099
Open
Tracked by #120

Disable Aggregate Targets for users with multiple facility_ids #114

michaelkohn opened this issue Apr 29, 2024 · 4 comments · May be fixed by medic/cht-core#9099
Assignees
@latin-panda
Labels
Supervisor

Comments

@michaelkohn
Copy link
Member

#6543 allows users to have more than one facility_id.

It doesn't make sense to aggregate targets data across mutliple facility_ids so we'd need a significant UI change to accommodate this. For the MVP, we've chosen just to disable aggregate targets for users with multiple facility_ids.

See full list of changes here
@michaelkohn michaelkohn mentioned this issue Apr 30, 2024
Open
6 tasks
@latin-panda latin-panda self-assigned this May 6, 2024
@latin-panda latin-panda linked a pull request May 7, 2024 that will close this issue
feat(#6543): disable aggregate targets for users with multiple facility_ids medic/cht-core#9099
Open
5 tasks
@latin-panda
Copy link
Collaborator

PR ready for review waiting for feedback.

@latin-panda
Copy link
Collaborator

This is complete and approved by reviewers, but I would like to wait until Diana finishes her part to not get in the way in some way.

@latin-panda
Copy link
Collaborator

This has been rebased, and the tests are working. No major changes are expected, so it's ready. I'm just waiting for Diana's 6543-multi-facility.

@latin-panda
Copy link
Collaborator

latin-panda commented May 22, 2024 •
edited

@Benmuiruri might need to take over and get it to the finish line

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@latin-panda latin-panda

Labels
Supervisor
Projects
Care Teams
Status: In Progress
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat(#6543): disable aggregate targets for users with multiple facility_ids medic/cht-core
2 participants
@michaelkohn @latin-panda