Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

User organization_id can't be overwritten #184

Open
GabeIsman opened this issue Jan 14, 2016 · 6 comments
Open

User organization_id can't be overwritten #184

GabeIsman opened this issue Jan 14, 2016 · 6 comments
Assignees

Comments

@GabeIsman
Copy link
Contributor

When I try to save an empty string to the organization_id nothing happens, no error, just no change in the data.

@thequbit
Copy link
Contributor

Herm. Weird. I may need to substitute the empty string for null. I assume you can't actually PUT with null, right?

@thequbit
Copy link
Contributor

@GabeIsman if I set my org to "WXXI" and hit save, all works great. If I the edit it, and delete the contents of the text box and hit save, it sends the org id for WXXI in the json payload, not "" or null. I think I've got the fix in the server, but don't have a solid way to test it ...

@GabeIsman
Copy link
Contributor Author

Hmm. Looking into it. Seems to be something unexpected happening in
backbone forms code.

On Thu, Jan 14, 2016 at 7:06 PM, Timothy Duffy notifications@github.com
wrote:

@GabeIsman https://github.com/GabeIsman if I set my org to "WXXI" and
hit save, all works great. If I the edit it, and delete the contents of the
text box and hit save, it sends the org id for WXXI in the json payload,
not "" or null. I think I've got the fix in the server, but don't have a
solid way to test it ...


Reply to this email directly or view it on GitHub
#184 (comment)
.

@GabeIsman
Copy link
Contributor Author

Well I was wrong about the location, but man what a nasty little bug. Apparently typeahead.js doesn't fire a 'change' event when the value of the input is the empty string. Fix is up in a PR now.

@GabeIsman
Copy link
Contributor Author

To be clear, this is still an issue, you'll just be able to test your fix now.

@thequbit
Copy link
Contributor

Gotcha. Will test and submit in the AM. Nice find.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants