Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Player crashes when parsing VTT file whose last track is empty #2835

Open
thecontstruct opened this issue Dec 17, 2020 · 0 comments · May be fixed by #2836
Open

Player crashes when parsing VTT file whose last track is empty #2835

thecontstruct opened this issue Dec 17, 2020 · 0 comments · May be fixed by #2836
Labels
Bug

Comments

@thecontstruct
Copy link

If you try to use something like this:

WEBVTT

00:00:00.000 --> 00:00:15.800 align:middle line:90%
Hello world

00:00:15.800 --> 00:00:19.800 align:middle line:90%

the webvtt track parser method in tracks.js will crash on line 905 cause the initial text check in the ternary condition does an explicit check against null instead of null and undefined.
@thecontstruct thecontstruct linked a pull request Dec 30, 2020 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fixed 2835 thecontstruct/mediaelement
2 participants
@thecontstruct @digitas-git