Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Filters for PSM-Peptides using Search Engine provisioning #124

Open
1 of 2 tasks
ypriverol opened this issue Oct 31, 2018 · 3 comments
Open
1 of 2 tasks

Filters for PSM-Peptides using Search Engine provisioning #124

ypriverol opened this issue Oct 31, 2018 · 3 comments
Assignees

Comments

@ypriverol
Copy link
Contributor

ypriverol commented Oct 31, 2018

Some pipelines need to filter PSMs taking into account the Search Engine provisioning (which search engines have identified the corresponding spectrum), we see two cased here:

  • Filter Peptides that are not identified by all search engines. PR https://github.com/mpc-bioinformatics/pia/pull/123

  • Filter peptides identifications if the corresponding spectrum was identified with different sequences by each search engine. For example Spectrum A identified by SearchEngine A with sequence A and by Search Engine B with sequence B. We should be able to remove that case with a filter.

@ypriverol ypriverol self-assigned this Oct 31, 2018
@julianu
Copy link
Contributor

julianu commented Nov 27, 2018

There is a new filter named "PSM_SET_CONTAINS_SCORE_FILTER" now (see PR #123).
This works like a normal literal filter and only PSM sets containing the given score are passed on. If you require more than one (like all) scores, just add all. The test-file SearchEngineFilterTest demonstrates this in more detail.

@ypriverol
Copy link
Contributor Author

I will close the issue.

@julianu
Copy link
Contributor

julianu commented Nov 27, 2018

No, the second task is still missing ;)

@julianu julianu reopened this Nov 27, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants