Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] - UX: Re-ordering labels on shopping list #3426

Closed
6 tasks done
boc-the-git opened this issue Apr 5, 2024 · 1 comment · Fixed by #3540
Closed
6 tasks done

[BUG] - UX: Re-ordering labels on shopping list #3426

boc-the-git opened this issue Apr 5, 2024 · 1 comment · Fixed by #3540
Labels
bug: confirmed bug Something isn't working good first issue Good for newcomers

Comments

@boc-the-git
Copy link
Collaborator

boc-the-git commented Apr 5, 2024

First Check

  • This is not a feature request.
  • I added a very descriptive title to this issue (title field is above this).
  • I used the GitHub search to find a similar issue and didn't find it.
  • I searched the Mealie documentation, with the integrated search.
  • I already read the docs and didn't find an answer.
  • This issue can be replicated on the demo site (https://demo.mealie.io/).

What is the issue you are experiencing?

The UX for re-ordering shopping lists is bad.
There is only a "cancel" button, though its effect is "close". Updates to the order appear to be saved in real time when you drag and drop; though I didn't look into it extensively.

Hitting "cancel" certainly does not "undo" the changes you'd made.

There's probably 2 solutions here.. either reword "cancel" to "close" (easier), or implement actual "cancel" and "save" functionality. The former is fine.

image

Steps to Reproduce

On a shopping list, toggle label sorting, then re-order the labels.

Please provide relevant logs

N/A

Mealie Version

Assume this is applicable to all versions.

Version
nightly
Build
de142c47df8486ee8dad17ad9947bcc4d5b8a6b2

Deployment

Docker (Linux)

Additional Deployment Details

No response

@boc-the-git boc-the-git added bug Something isn't working triage bug: confirmed good first issue Good for newcomers and removed triage labels Apr 5, 2024
@michael-genson
Copy link
Collaborator

As the one who implemented it I agree it's awful. I vote for the latter - making it a proper save/cancel.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug: confirmed bug Something isn't working good first issue Good for newcomers
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants