Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] - 1/3rd not recognized as quantity by parser #3318

Open
6 tasks done
JvdMaat opened this issue Mar 15, 2024 · 8 comments
Open
6 tasks done

[BUG] - 1/3rd not recognized as quantity by parser #3318

JvdMaat opened this issue Mar 15, 2024 · 8 comments
Labels
bug: confirmed bug Something isn't working

Comments

@JvdMaat
Copy link

JvdMaat commented Mar 15, 2024

First Check

  • This is not a feature request.
  • I added a very descriptive title to this issue (title field is above this).
  • I used the GitHub search to find a similar issue and didn't find it.
  • I searched the Mealie documentation, with the integrated search.
  • I already read the docs and didn't find an answer.
  • This issue can be replicated on the demo site (https://demo.mealie.io/).

What is the issue you are experiencing?

Then trying to parse ingredients that contain 1/3rd of something (eg 1/3 cup), the parser lists 0 as quantity

Steps to Reproduce

From demo site, import recipe from URL: https://www.wellplated.com/slow-cooker-honey-garlic-chicken/#wprm-recipe-container-37253
Save, disable the Disable ingredient amounts, and then parse it.
Both 2nd and 3rd (soy sauce and honey) fail to get a proper quantity
I left https://demo.mealie.io/g/home/r/slow-cooker-honey-garlic-chicken unparsed for ease of reference. (just don't save and can be re-used)

Please provide relevant logs

image

Mealie Version

1.3.2 & nightly (issue occurs on demo.mealie.io)

Deployment

Docker (Linux)

Additional Deployment Details

No response

@JvdMaat JvdMaat added bug Something isn't working triage labels Mar 15, 2024
@JvdMaat
Copy link
Author

JvdMaat commented Mar 15, 2024

Just a quick addition. Only fails in NLP (Natural Language Parser). Brute parser catches the 1/3rd no problem.

@cmintey
Copy link
Contributor

cmintey commented Mar 15, 2024

Can confirm I noticed this as well when importing a recipe the other day

@camillerimichael
Copy link

Can I add that cup is recognised but not cups. It seems plurals are a blind spot.

@michael-genson
Copy link
Collaborator

Can I add that cup is recognised but not cups. It seems plurals are a blind spot.

Have you added plurals to your units? The parser looks at those which usually solves that problem

@camillerimichael
Copy link

The recipe had plurals to being with. I'll play around more with the parser, I only used the first one.

@hay-kot
Copy link
Collaborator

hay-kot commented Mar 25, 2024

FYI, I'm doing work for Recipinned in this repo that greatly improved the parsing, but it uses a totally different model/strategy

https://github.com/hay-kot/recipes-api

It would be a pretty big lift to get it integrated into Mealie, but it's totally possible if someone wants to tackle it.

Copy link
Contributor

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@JvdMaat
Copy link
Author

JvdMaat commented Apr 25, 2024

Still an issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug: confirmed bug Something isn't working
Projects
None yet
Development

No branches or pull requests

6 participants