Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] unable to "control" md code block formatting #382

Closed
2 tasks done
dogmatic69 opened this issue Mar 11, 2024 · 3 comments
Closed
2 tasks done

[BUG] unable to "control" md code block formatting #382

dogmatic69 opened this issue Mar 11, 2024 · 3 comments
Labels
feature request/enhancement New feature or request

Comments

@dogmatic69
Copy link

If you want to ask for support or request features, sponsor the project and contact me over email.

  • I have searched for similar issues in both open and closed tickets and cannot find a duplicate.
  • I have read the documentation and cannot find an answer.

Describe the bug

Unable to control code blocks created from markdown triple back ticks. From a quick look at the code, seems to do internal things that does not pass through any configurations (eg: theme)

Reproduction

Simple mardkown setup with code blocks results in black blocks of code (due to "auto" dark theme due to system settings)

Expected behavior

I'm using this for non technical use, so I want the code block to be styled more simply but don't seem to be able to do anything related to style for mardkown code blocks.

Screenshots
image

@dogmatic69 dogmatic69 added the bug Something isn't working label Mar 11, 2024
@petyosi
Copy link
Contributor

petyosi commented Mar 11, 2024

This is a missing feature. The code blocks editor has be migrated to a plain codemirror setup (they use the sandpack config), and from there it's fairly easy to make them themeable, like the diff/source editors.

Happy to accept a PR.

@petyosi petyosi added feature request/enhancement New feature or request and removed bug Something isn't working labels Mar 11, 2024
@dogmatic69
Copy link
Author

Ok, at least I know. Not really familiar with this all so won't be able to make a PR.

@petyosi
Copy link
Contributor

petyosi commented May 19, 2024

This is solved (solved a while back), just missed closing this feature. The codemirror plugin accepts codemirror options, which let you pass a theme plugin of your choice.

@petyosi petyosi closed this as completed May 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature request/enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants