Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The Link Dialog doesn't work on mobile #327

Open
hahhen opened this issue Jan 21, 2024 · 7 comments
Open

The Link Dialog doesn't work on mobile #327

hahhen opened this issue Jan 21, 2024 · 7 comments
Labels
bug Something isn't working

Comments

@hahhen
Copy link
Contributor

hahhen commented Jan 21, 2024

Steps to reproduce:

On a mobile device:
Open the demo
Click the link button

When nothing is selected, it just doesn't do anything
When something is selected, it opens and closes very fast

@petyosi petyosi added the bug Something isn't working label Jan 21, 2024
@petyosi
Copy link
Contributor

petyosi commented Jan 21, 2024

By mobile do you mean iOS or Android?

@hahhen
Copy link
Contributor Author

hahhen commented Jan 21, 2024

My phone is an Android device, I haven't tested it on iOS.

@petyosi
Copy link
Contributor

petyosi commented Jan 21, 2024

I see. Might take me some time to set up a convenient testing environment. If you're feeling like it, I'm happy to accept a contribution.

@hahhen
Copy link
Contributor Author

hahhen commented Jan 21, 2024

I'll try to see what I can do, but I'm pretty much a newbie on React development (and I'm not used to Radix either)

@hahhen
Copy link
Contributor Author

hahhen commented Jan 22, 2024

I asked my friend to test on his iPhone. He said it doesn't work either

@petyosi
Copy link
Contributor

petyosi commented Jan 23, 2024

I tested it on a mobile device, and it seems like the popup opening and the form size does not work well for mobile (even leaving the form closing aside). If you're going to develop an UI that needs to work on mobile, I think the best option is to build a UI that's specific for the small screen - even a small browser prompt would work I guess.

@braincore
Copy link
Contributor

@hahhen If you're still interested in doing this, it was easy enough to use the LinkDialog option in the linkDialogPlugin. I started with the default implementation in the repo (changing the imports to @mdxeditor/editor) and modified it to be mobile-friendly.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants