Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DVGeometry allows ref axis to be added after a finalize is called #68

Open
bbrelje opened this issue Feb 28, 2021 · 1 comment
Open
Labels
bug Something isn't working

Comments

@bbrelje
Copy link
Collaborator

bbrelje commented Feb 28, 2021

Description

DVGeometry will allow the user to addRefAxis() following a finalize call without raising an error or warning. Instead, an obscure error is raised, e.g.

Traceback (most recent call last):
  File "runFFDExample.py", line 43, in <module>
    stlmesh.vectors[:,1,:] = DVGeo.update('mesh_v1')
  File "/home/ben/packages/pygeo/pygeo/DVGeometry.py", line 1281, in update
    self._complexifyCoef()
  File "/home/ben/packages/pygeo/pygeo/DVGeometry.py", line 2746, in _complexifyCoef
    self.rot_x[key].coef = self.rot_x[key].coef.astype('D')
AttributeError: 'DVGeometry' object has no attribute 'rot_x'

Steps to reproduce issue

  1. Create a DVGeometry object
  2. Add a pointset
  3. Update the pointset
  4. Add a ref axis
  5. Try to update again

Current behavior

Raises obscure error potentially much later than when the refAxis is added

Expected behavior

Should raise error at the time the ref axis is added if the system is finalized

@ewu63 ewu63 added the bug Something isn't working label May 10, 2021
@marcomangano
Copy link
Contributor

@bernardopacini @sseraj as you mentioned you are working on testing, there might also be an opportunity to fix and test this issue (I also call myself in to work on this @marcomangano )

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants