Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor handling of multiple DVGeo objects with DVCon #57

Open
anilyil opened this issue Jan 18, 2021 · 1 comment
Open

Refactor handling of multiple DVGeo objects with DVCon #57

anilyil opened this issue Jan 18, 2021 · 1 comment
Labels
enhancement New feature or request

Comments

@anilyil
Copy link
Contributor

anilyil commented Jan 18, 2021

Description of feature

The PR #52 introduces a way to use multiple DVGeometry objects with a single DVConstraints object. So far, only @bbrelje uses these. There is a separate development of DVGeometryMulti that is used to handle intersecting components. I also implemented a similar functionality but in a different way. In that work, DVGeometryMulti class handles multiple component DVGeometries, and adjusts the naming for pyoptsparse etc.

Ideally we want to have a consistent implementation so both approaches can function together.

Potential solution

Around April 2021, we will refactor the pygeo code with @bbrelje to fix this consistency issue. At the same time, I will also merge the outstanding work in my development branch: https://github.com/anilyil/pygeo/tree/dev The main addition will be the DVGeometryMulti code, but there are other minor API changes for other pygeo classes.

@sseraj sseraj changed the title Merge the dvgeomulti code and refactor handling of multiple dvgeos across pygeo Refactor handling of multiple DVGeo objects with DVCon Aug 2, 2022
@sseraj
Copy link
Contributor

sseraj commented Aug 2, 2022

We merged DVGeoMulti in #113 but did not refactor the handling of multiple DVGeo objects with DVCon. I updated the issue title to reflect this.

@sseraj sseraj added the enhancement New feature or request label Aug 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants