Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Complex tests generate complex reference values #221

Open
ewu63 opened this issue May 24, 2022 · 0 comments
Open

Complex tests generate complex reference values #221

ewu63 opened this issue May 24, 2022 · 0 comments
Labels
bug Something isn't working maintenance This is for maintaining the repo

Comments

@ewu63
Copy link
Collaborator

ewu63 commented May 24, 2022

Description

Due to the build bot failure last night, we realized that some tests are generating complex values while the reference file contains only the real part. We should fix the tests so that the values we compare are real and not complex.

For ADflow the following tests are impacted:

test_jacVecProdFWD.py:TestJacVecFwdCS_0_euler_scalar_jst_tut_wing_1core.cmplx_test_wDot
test_jacVecProdFWD.py:TestJacVecFwdCS_0_euler_scalar_jst_tut_wing_1core.cmplx_test_xDvDot
test_jacVecProdFWD.py:TestJacVecFwdCS_0_euler_scalar_jst_tut_wing_1core.cmplx_test_xVDot

Steps to reproduce issue

  1. Run these tests
  2. Observe the values such as ||dR/dw * wDot||, ||dR/dalpha||, and ||dR/dXv * xVDot||

Current behavior

They are complex

Expected behavior

They should be real

@ewu63 ewu63 added bug Something isn't working maintenance This is for maintaining the repo labels May 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working maintenance This is for maintaining the repo
Projects
None yet
Development

No branches or pull requests

1 participant