Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SA-R implementation is incorrect #156

Open
sseraj opened this issue Aug 5, 2021 · 0 comments
Open

SA-R implementation is incorrect #156

sseraj opened this issue Aug 5, 2021 · 0 comments
Labels
bug Something isn't working

Comments

@sseraj
Copy link
Contributor

sseraj commented Aug 5, 2021

Description

There are two problems with the SA-R implementation here (the same code also appears in the blockette code) when compared to the TMR website:

  1. The min function is missing the minus omega in the second argument. As a result, the min always evaluates to zero and SA-R solutions are identical to SA.
  2. The if statement is checked for both strain and vorticity production, but SA-R is only valid for vorticity production.
@sseraj sseraj added the bug Something isn't working label Aug 5, 2021
@sseraj sseraj self-assigned this Aug 5, 2021
@marcomangano marcomangano mentioned this issue Apr 4, 2022
Open
@sseraj sseraj removed their assignment Mar 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@sseraj