Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix displacement transfer #323

Open
shamsheersc19 opened this issue Jul 5, 2020 · 1 comment
Open

Fix displacement transfer #323

shamsheersc19 opened this issue Jul 5, 2020 · 1 comment
Assignees
Labels
bug Something isn't working

Comments

@shamsheersc19
Copy link
Contributor

Type of issue

What types of issue is it?

  • Bugfix (non-breaking change which fixes an issue)

Description

The implemented displacement transfer scheme doesn't match the scheme in the OAS paper. (But, this is not a major concern for reasonably fine meshes.)

Current behavior

See #322

Expected behavior

The work done for the aero and structures should match for all mesh levels (see #322).

@shamsheersc19 shamsheersc19 added the bug Something isn't working label Jul 5, 2020
@kanekosh
Copy link
Contributor

I implemented a displacement transfer that is (almost) identical to the scheme in the paper. Now I confirmed that the new implementation satisfies the work conservation even with a coarse mesh.
With a 5*2 mesh of CRM, the relative difference between aero and structural works is:

v2.2.0: 0.74%
v2.2.1: 29.0%
Newest: 0.0047%

I believe the tiny difference comes from the nonlinear rotational transfer of the code, as opposed to the linear assumption in the paper. But this effect is small enough, and I'm not going to fix this part.

Now I'll be implementing the partial derivatives and updating the doc as needed. This will take a while because I had to change the mesh data structure throughout the VLM module.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants