Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sidebars created by QuicklinksWithSubPages have duplicate entries #10572

Open
3 tasks done
chrisdavidmills opened this issue Feb 22, 2024 · 5 comments
Open
3 tasks done
Labels
accepting PR We invite you to open a PR to resolve this issue. 🐛 bug Something isn't working, or isn't working as expected macros tracking issues related to kumascript macros p3 We don't have visibility when this will be addressed. sidebar/toc Sidebar and table of contents

Comments

@chrisdavidmills
Copy link
Contributor

Summary

Sidebars created using the QuicklinksWithSubPages macro look really bad, and they contain duplicate links. See https://developer.mozilla.org/en-US/docs/Web/Privacy/Firefox_tracking_protection for an example.

We are about to update this page, so also see mdn/content#30107 (comment) for a screenshot of what it used to look like.

URL

https://developer.mozilla.org/en-US/docs/Web/Privacy/Firefox_tracking_protection

Reproduction steps

  1. Go to https://developer.mozilla.org/en-US/docs/Web/Privacy/Firefox_tracking_protection

Expected behavior

A nice sidebar, without duplicate links

Actual behavior

A sidebar that looks bad, has duplicate links, and is inconsistent with other MDN sidebars in look and feel.

Device

Desktop

Browser

Firefox

Browser version

Pre-release (e.g. Beta, Nightly or Canary)

Operating system

Mac OS

Screenshot

No response

Anything else?

No response

Validations

@github-actions github-actions bot added the needs triage Triage needed by staff and/or partners. Automatically applied when an issue is opened. label Feb 22, 2024
@argl
Copy link
Contributor

argl commented Mar 4, 2024

@chrisdavidmills Is this still an issue? The page mentioned looks fine, no duplicates in the sidebar.

@chrisdavidmills
Copy link
Contributor Author

@chrisdavidmills Is this still an issue? The page mentioned looks fine, no duplicates in the sidebar.

@argl This is because we merged the content PR where the issue was first noticed, and it now uses a different mechanism of creating the sidebar. You can see what it used to look like (when borked) at this comment: mdn/content#30107 (comment)

@argl
Copy link
Contributor

argl commented Mar 5, 2024

@chrisdavidmills Ok, understood, thank you!

@argl argl added 🐛 bug Something isn't working, or isn't working as expected macros tracking issues related to kumascript macros needs decision from engineering sidebar/toc Sidebar and table of contents and removed needs triage Triage needed by staff and/or partners. Automatically applied when an issue is opened. labels Mar 5, 2024
@caugner
Copy link
Contributor

caugner commented Mar 15, 2024

I think we should indeed create a PrivacySidebar macro for consistency, which can then also be used in the translated pages (see here and here).

@caugner caugner added p3 We don't have visibility when this will be addressed. accepting PR We invite you to open a PR to resolve this issue. and removed needs decision from engineering labels Mar 20, 2024
@github-actions github-actions bot added the idle label Apr 20, 2024
@mirunacurtean
Copy link

Noticed a potential side effect of this. On pages with duplicate sidebar entries like https://developer.mozilla.org/en-US/docs/Web/Privacy/Privacy_sandbox or https://developer.mozilla.org/en-US/docs/Web/EXSLT/math, when selecting one of those topics the whole section gets highlighted.
image
This does not happen when selecting one of the sub-entries in that section.
image

@github-actions github-actions bot removed the idle label May 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
accepting PR We invite you to open a PR to resolve this issue. 🐛 bug Something isn't working, or isn't working as expected macros tracking issues related to kumascript macros p3 We don't have visibility when this will be addressed. sidebar/toc Sidebar and table of contents
Projects
None yet
Development

No branches or pull requests

4 participants