Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Error checking on inputs modal #6

Open
mdmurbach opened this issue Oct 24, 2017 · 0 comments
Open

Error checking on inputs modal #6

mdmurbach opened this issue Oct 24, 2017 · 0 comments

Comments

@mdmurbach
Copy link
Owner

Selecting a fitting procedure requires user input to determine best guesses (equivalent circuit fitting) or additional parameters like cell capacity (physics-based fitting). Currently there is no checking on these inputs and the fitting will simply fail if a parameter is not provided or an aphysical choice is made.

Tests should be added and the user either warned or the analysis stopped with a useful error message.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant