Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Any ideas why the catchment delineated has holes? How can I filled the holes? #224

Open
staceyzhang-cbcl opened this issue Aug 18, 2023 · 5 comments

Comments

@staceyzhang-cbcl
Copy link

I was testing the functions with two DEM files. Both catchments I delineated with a randomly picked pour point had holes in them where I dont think there should be. How do I eliminate them? Did I do something wrong?

For the first DEM, I filled pits, depressions and resolved flats. The first two was good, with assert not depressions.any()/pits.any() returning nothing. But the flats seemed not resolved. Could it be the reason?

Thank you!

image
image

@mdbartos
Copy link
Owner

Greetings. When running resolve_flats, try setting a lower epsilon value, e.g.:

resolve_flats(..., eps=1e-7)

@staceyzhang-cbcl
Copy link
Author

Thanks so much for your quick response!

This solved one of my two DEM problems. The second DEM still has one hole (but not two, I take that as a partial success). I wonder how low the epsilon value can be. I tried eps=1e-11 but it still didn't resolve all flats.

@mdbartos
Copy link
Owner

@Eric-Jenkins : Could be a good test case to look at.

@staceyzhang-cbcl : Are you able to send the DEM?

@staceyzhang-cbcl
Copy link
Author

I tried. But the file is too large to upload. It's 125MB after compression.

@staceyzhang-cbcl
Copy link
Author

OK, I uploaded it to my google drive.

The pour point is 576410.1845, 5048888.3975.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants