check for undesirable quotes #260
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mbrt
requested changes
Jun 16, 2022
|
@mbrt thank you for your help and patience. |
mbrt
requested changes
Jun 18, 2022
mbrt
requested changes
Jun 20, 2022
|
I think this is finally "correct" and I have squashed and reworded my commits appropriately. |
mbrt
requested changes
Jun 20, 2022
mbrt
approved these changes
Jun 20, 2022
|
Thank you @mefuller! This is good to go. |
|
Thank you @mbrt |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #66.
It's also my first attempt to meaningfully work on go/golang, so any guidance or pointers are very appreciated
Since processed strings are enclosed in outer double quotes, I test for a double quote contained anywhere as well as for enclosing single quotes, which would then be captured inside double quotes and result in a mismatch
Thanks