Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support boolean avoidSplitting property in rules #373

Closed
wants to merge 1 commit into from
Closed

Support boolean avoidSplitting property in rules #373

wants to merge 1 commit into from

Conversation

dbarnett
Copy link

@dbarnett dbarnett commented Nov 28, 2023 •
edited

!! TODO: Finalize naming/structure and add docs & tests. !!

This signals to the converter to avoid arbitrarily splitting "or" conditions into multiple separate filters when it's not strictly necessary to split.

Fixes #372.

@dbarnett
Support boolean avoidSplitting property in rules
8484b9d 
This signals to the converter to avoid arbitrarily splitting "or"
conditions into multiple separate filters when it's not strictly
necessary to split.
@dbarnett dbarnett mentioned this pull request Nov 28, 2023
Open
@github-actions GitHub Actions
Copy link
Contributor

This pull request is stale because it has been open for 30 days without activity.
This will be closed in 7 days, unless you add the 'lifecycle/keep-alive' label or comment.

@github-actions github-actions bot added the lifecycle/stale Denotes an issue or PR has remained open with no activity, has become stale and will be auto-closed. label Dec 29, 2023
@dbarnett
Copy link
Author

Still being discussed in the issue I linked, AFAICT no real benefit to closing as stale in the meantime but if you want to that's fine.

@mbrt mbrt removed the lifecycle/stale Denotes an issue or PR has remained open with no activity, has become stale and will be auto-closed. label Jan 4, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Feb 4, 2024

This pull request is stale because it has been open for 30 days without activity.
This will be closed in 7 days, unless you add the 'lifecycle/keep-alive' label or comment.

@github-actions github-actions bot added the lifecycle/stale Denotes an issue or PR has remained open with no activity, has become stale and will be auto-closed. label Feb 4, 2024
@mbrt mbrt marked this pull request as draft February 9, 2024 13:44
@github-actions github-actions bot removed the lifecycle/stale Denotes an issue or PR has remained open with no activity, has become stale and will be auto-closed. label Feb 15, 2024
@github-actions GitHub Actions
Copy link
Contributor

This pull request is stale because it has been open for 30 days without activity.
This will be closed in 7 days, unless you add the 'lifecycle/keep-alive' label or comment.

@github-actions github-actions bot added the lifecycle/stale Denotes an issue or PR has remained open with no activity, has become stale and will be auto-closed. label Mar 17, 2024
@github-actions github-actions bot closed this Mar 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
lifecycle/stale Denotes an issue or PR has remained open with no activity, has become stale and will be auto-closed.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Why does gmailctl split this kind of "or" filter into separate rules?
2 participants
@dbarnett @mbrt