[Bug] Reserved characters in NAME interact with env.sh during backup?

[Spunkie]

First is an error about .bash_profile that logs at the same time regardless of what the server NAME is set to. And the 2nd error only pops up if I put a space( ) and a ! character in the server NAME. For example with NAME="abc defg!" the error looks like this:

==> /home/steam/valheim/logs/auto-backup.out <==
/env.sh: line 7: /home/steam/.bash_profile: No such file or directory
/env.sh: line 20: export: `defg!': not a valid identifier
[Valheim][steam]: Skipping backup, no players are online.

If you remove either character NAME="abcdefg!" or NAME="abc defg" then the error does not happen, but a name with both seems to trigger it. I didn't have time to test for other characters in a server NAME, that might cause the same behavior, but I imagine there are some more creeping about.

This is on a stock amazon x86 EC2 instance running Amazon Linux 2, Kernel 5.10.

---

There is also another random error that pops up consistently at boot and shutdown:

[Valheim][steam]: Running Install...
[Valheim][steam]: Attempting to update before launching the server!
parse error: Invalid numeric literal at line 1, column 6

Backup on shutdown triggered! Running backup tool...
parse error: Invalid numeric literal at line 1, column 6

[mbround18]

@Spunkie a name with a space and an exclamation mark?

[DiskCrasher]

@mbround18 Yes, it's quoted:

NAME: "Shooting Star"

On startup the log shows:

[Valheim][steam]: Name: Shooting

[mbround18]

My guess is this is due to the translation between docker and env vars. I can take a look at it and see if i can improve the env var translation.

[spannerman79]

@DiskCrasher There is a work around until @mbround18 gets around it.

Double escape the space.

Log:

[Valheim][steam]: Name: Shooting Star

en var:

NAME: "Shooting\\ Star"

I didn't do anything fancy for testing but for replication purpose;

version: "3"
services:
  valheim:
    image: mbround18/valheim:latest
    stop_signal: SIGINT
    ports:
      - "2456:2456/udp"
      - "2457:2457/udp"
      - "2458:2458/udp"
    environment:
      PORT: 2456
      NAME: "Shooting\\ Star"
      WORLD: "Dedicated"
      PASSWORD: "Banana Phone"
      TZ: "America/Chicago"
      PUBLIC: 1
    volumes:
      - ./saves:/home/steam/.config/unity3d/IronGate/Valheim
      - ./server:/home/steam/valheim

[mbround18]

I have quoted the string in the template you no longer need to escape the space. https://github.com/mbround18/valheim-docker/releases/tag/v2.4.0