Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

In the codepen example, the radio buttons seem wrong #54

Open
julienw opened this issue Oct 22, 2020 · 0 comments
Open

In the codepen example, the radio buttons seem wrong #54

julienw opened this issue Oct 22, 2020 · 0 comments

Comments

@julienw
Copy link

julienw commented Oct 22, 2020

STR:

  • Open the codepen example
  • Click on Radio 1 (the text, not the button itself)

=> nothing happens

Also click on Radio 1 (the button itself) and then Radio 1
=> both of them are now selected.

I believe you need to change:

<label for=radio-choice-1>Radio 1:</label> <input type=radio name=radio-1 id=radio-1 tabindex=1 value=radio-1 /><br> <label for=radio-2>Radio 2:</label> <input type=radio name=radio-2 id=radio-2 tabindex=2 value=radio-2 />

to

<label for=radio-1>Radio 1:</label> <input type=radio name=radio id=radio-1 tabindex=1 value=radio-1 /><br> <label for=radio-2>Radio 2:</label> <input type=radio name=radio id=radio-2 tabindex=2 value=radio-2 />

That is, the for attribute for the first label is wrong, and the 2 names need to be the same.

Sorry I can't do a PR for the codepen demo :-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant