Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

some features are lost when -clean #546

Open
fran2a opened this issue Jun 1, 2022 · 6 comments
Open

some features are lost when -clean #546

fran2a opened this issue Jun 1, 2022 · 6 comments

Comments

@fran2a
Copy link

fran2a commented Jun 1, 2022

Hi,

I have an issue when applying -clean option on some data, I lose some features...

Here the test datas: https://e-nautia.com/fmp2a/disk/public/temp1.zip

Thanks

@mbloch
Copy link
Owner

mbloch commented Jun 1, 2022

I'll look into this... thanks for attaching a sample dataset :)

@mbloch
Copy link
Owner

mbloch commented Jun 3, 2022

I see what you mean... I will work on fixing this. Geometry errors like this can be hard to debug and fix, so it might take me a while.

@fran2a
Copy link
Author

fran2a commented Jun 3, 2022

Many thanks.

@fran2a
Copy link
Author

fran2a commented Jun 4, 2022

Just for my information, what kind of geometry errors have you noticed?
Thanks

@mbloch
Copy link
Owner

mbloch commented Jun 5, 2022

In my experience, geometry errors like this are generally related to the limited precision of JavaScript's floating point math operations. The -clean function detects all the places where pairs of line segments intersect each other. When two line segments are almost-but-not-quite parallel, or a vertex of one segment is located almost exactly along the second segment, then it becomes harder to reliably test if the segments intersect.

@fran2a
Copy link
Author

fran2a commented Jul 6, 2022

Hi.
No news on this issue? Seems to be challenging?
With my respect.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants