Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: Add Test Coverage Generation #699

Closed
1 task
jemiluv8 opened this issue Apr 30, 2024 · 4 comments · Fixed by #760
Closed
1 task

Feature: Add Test Coverage Generation #699

jemiluv8 opened this issue Apr 30, 2024 · 4 comments · Fixed by #760

Comments

@jemiluv8
Copy link

Feature Overview

The current rake test command doesn't generate test coverage report.
This can be useful especially for new features that require testing.

Requirements

  • Support generation of test coverage report when running tests

Implementation Suggestions

Probably integrate simplecov-ruby or similar compatible library for test coverage report generation

Designs

Not Applicable

Reminders

  • Make sure to review our contributing guidelines before starting on an issue
  • We do our best to define a clear spec for new features and fixes, but think of them as "suggestions", not "hard requirements". We welcome ideas and suggestions!
    • If you see missing requirements to this issue, please leave a comment below explaining what is missing and why it is important.
    • If you see a requirement that you think is incorrect or not optimal, please leave a comment explaining what you think needs to change below.
@jemiluv8
Copy link
Author

jemiluv8 commented Apr 30, 2024

@gathuku, FYI, I'm not a maintainer on this project and this issue doesn't have a bounty on it at the moment.
Also, you might want to ping the maintainers just in case they have something to add or even if they truly want test coverage on their project.

@gathuku
Copy link
Contributor

gathuku commented Apr 30, 2024

Sorry @jemiluv8 , no problem, let me remove my comment.

@zachgoll
Copy link
Collaborator

@jemiluv8 @gathuku I think we could add the simplecov gem to generate a coverage report, but given how early we are with this project, this should be for convenience only at the moment (i.e. a dev writing tests locally can easily see coverage to help them identify important areas that they missed)

In other words, we can set this up, but let's not enforce anything in CI for now.

@gathuku
Copy link
Contributor

gathuku commented Apr 30, 2024

Nice! @jemiluv8 can I help you with this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants